search

csharpvitamins / CSharpVitamins.ShortGuid

A convenience wrapper for dealing with base64 encoded Guids
MIT License
103 stars 20 forks source link

[PR] The proj files have been updated to enable SourceLink #3

Closed JTOne123 closed 4 years ago

JTOne123 commented 4 years ago

CSProj files have been updated to enable SourceLink in your nuget

[This pull request was created with an automated workflow]

I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.

We have to take 2 steps: 1) Please approve this pull request and make .NET a better place for .NET developers and their debugging. 2) Then just upload the .snupkg file to https://www.nuget.org/ (now you can find the snupkg file along with the .nuget file)

You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx

If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater

If you notice any flaws, please comment and I will try to make fixes manually

davetransom commented 4 years ago

Thanks @JTOne123 - I went to upload just the .snupkg to the existing 1.0.2 version on nuget, which was initially accepted, but then came back as "failed validation":

The uploaded symbols package contains pdb(s) for a corresponding dll(s) not found in the nuget package.

Do I need to publish a new version? Or is there an expectation that I should be able to just upload the .snupkg file?

NB: The .snupkg only contains the .pdb files. The .dll or .xml files are packaged in the .nupkg file.

JTOne123 commented 4 years ago

yes, upload both files together