search

csi-addons / kubernetes-csi-addons

CSI-Addons implementation and APIs for Kubernetes
Apache License 2.0
17 stars 37 forks source link

vendor: bump sigs.k8s.io/controller-tools from 0.14.0 to 0.15.0 in /tools in the k8s-dependencies group #550

Closed dependabot[bot] closed 5 months ago

dependabot[bot] commented 5 months ago

Bumps the k8s-dependencies group in /tools with 1 update: sigs.k8s.io/controller-tools.

Updates sigs.k8s.io/controller-tools from 0.14.0 to 0.15.0

Release notes

Sourced from sigs.k8s.io/controller-tools's releases.

v0.15.0

What's Changed

envtest

Dependency bumps

New Contributors

Full Changelog: https://github.com/kubernetes-sigs/controller-tools/compare/v0.14.0...v0.15.0

Commits
  • 473c028 Merge pull request #927 from pmalek/crd-xvalidation-add-messageExpression
  • 8dd0634 Merge pull request #930 from kubernetes-sigs/dependabot/github_actions/action...
  • 5464a63 Merge pull request #931 from kubernetes-sigs/dependabot/go_modules/github.com...
  • 1381be7 :seedling: Bump actions/checkout from 4.1.2 to 4.1.3
  • a40abf6 Merge pull request #929 from kubernetes-sigs/dependabot/github_actions/tj-act...
  • 9571d3c :seedling: Bump github.com/onsi/gomega from 1.32.0 to 1.33.0
  • 434b090 :seedling: Bump tj-actions/changed-files from 44.0.1 to 44.3.0
  • 04e6d44 feat(crdvalidation): add messageExpression support to XValidation marker
  • e159968 :sparkles: crd: allow specifying spec.preserveUnknownFields (#912)
  • 8cc57e3 Merge pull request #926 from sbueringer/pr-1.30
  • Additional commits viewable in compare view


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions
iPraveenParihar commented 5 months ago

Need to update go to 1.22

 > [builder 4/4] RUN make build:
0.286 cd ./tools && go build -o /workspace/go/src/github.com/csi-addons/kubernetes-csi-addons/bin/controller-gen ./vendor/sigs.k8s.io/controller-tools/cmd/controller-gen
0.293 go: k8s.io/api in vendor/modules.txt requires go >= 1.22.0 (running go 1.21.9; GOTOOLCHAIN=local)
0.294 make: *** [Makefile:232: controller-gen] Error 1
nixpanic commented 5 months ago

Need to update go to 1.22

 > [builder 4/4] RUN make build:
0.286 cd ./tools && go build -o /workspace/go/src/github.com/csi-addons/kubernetes-csi-addons/bin/controller-gen ./vendor/sigs.k8s.io/controller-tools/cmd/controller-gen
0.293 go: k8s.io/api in vendor/modules.txt requires go >= 1.22.0 (running go 1.21.9; GOTOOLCHAIN=local)
0.294 make: *** [Makefile:232: controller-gen] Error 1

@iPraveenParihar are you planning to update that?

iPraveenParihar commented 5 months ago

Need to update go to 1.22

 > [builder 4/4] RUN make build:
0.286 cd ./tools && go build -o /workspace/go/src/github.com/csi-addons/kubernetes-csi-addons/bin/controller-gen ./vendor/sigs.k8s.io/controller-tools/cmd/controller-gen
0.293 go: k8s.io/api in vendor/modules.txt requires go >= 1.22.0 (running go 1.21.9; GOTOOLCHAIN=local)
0.294 make: *** [Makefile:232: controller-gen] Error 1

@iPraveenParihar are you planning to update that?

@nixpanic, Yes, do I need to raise a different PR? Or I can switch to this PR branch and make change?