search

csi-addons / kubernetes-csi-addons

CSI-Addons implementation and APIs for Kubernetes
Apache License 2.0
17 stars 33 forks source link

replication: add missing VRC name for VGR #597

Closed Madhu-1 closed 2 weeks ago

Madhu-1 commented 2 weeks ago

we need to have a VRC name to create the VR, this PR adds a new field to the VGR to pass down the VRC name for the VolumeReplication object.

nixpanic commented 2 weeks ago

@Madhu-1 , the abbreviations make it really difficult to understand the explanation.

I don't understand why a VolumeGroupReplication needs the VolumeReplicationClassName, why is VolumeGroupReplicationClassName not sufficient?

Or, should the VolumeReplicationClassName not be a member of VolumeGroupReplicationClass?

Madhu-1 commented 2 weeks ago

@Madhu-1 , the abbreviations make it really difficult to understand the explanation.

I don't understand why a VolumeGroupReplication needs the VolumeReplicationClassName, why is VolumeGroupReplicationClassName not sufficient?

Or, should the VolumeReplicationClassName not be a member of VolumeGroupReplicationClass?

@nixpanic we have an option either to reuse the same group class for replication as well or introduce a new class field for the replication, IMO we should not make VolumeReplicationClassName as a member of VolumeGroupReplicationClass