search

csi-addons / kubernetes-csi-addons

CSI-Addons implementation and APIs for Kubernetes
Apache License 2.0
17 stars 33 forks source link

reclaimspace: fix schedule handling #604

Closed iPraveenParihar closed 4 days ago

iPraveenParihar commented 1 week ago

In my earlier PR https://github.com/csi-addons/kubernetes-csi-addons/pull/585, I missed few changes 😞

This commit addresses a bug in determineScheduleAndRequeue where the check for schedule from the StorageClass annotations is never reached.

Madhu-1 commented 1 week ago

@iPraveenParihar can you please add a unit testing to cover a few test cases for PVC and SC and not found case for namespace for now?

iPraveenParihar commented 1 week ago

@iPraveenParihar can you please add a unit testing to cover a few test cases for PVC and SC and not found case for namespace for now?

@Madhu-1 added!

iPraveenParihar commented 4 days ago

@Madhu-1 @Rakshith-R PTAL.