search

csi-addons / kubernetes-csi-addons

CSI-Addons implementation and APIs for Kubernetes
Apache License 2.0
17 stars 33 forks source link

Support VolumeGroupReplication with VR #605

Open Madhu-1 opened 1 week ago

Madhu-1 commented 1 week ago

This PR adds the support for replicating the group with volumegrouplication

Madhu-1 commented 2 days ago

Almost everything looks good to me.

small nit: I noticed there's no group-replication-client_test.go similar to volume-replication-client_test.go. maybe we need to add that test file or combine both volume and group to be tested as interface functions in replication-client_test.go?

@Rakshith-R I did consider that I don't see any value for volume-replication-client_test.go as its not testing anything, i do have a plan to remove it in followup and replace that with proper tests

Madhu-1 commented 1 day ago

@iPraveenParihar You have requested changes on this one, can you please review it again. @nixpanic can you please also review it again, made all the changes