search

csi-addons / kubernetes-csi-addons

CSI-Addons implementation and APIs for Kubernetes
Apache License 2.0
17 stars 33 forks source link

Migrate project from go v3 layout to v4 #606

Open black-dragon74 opened 1 week ago

black-dragon74 commented 1 week ago

This patch migrates the project structure from kubebuilder's GO v3 to v4 layout.

Fixes: #587

black-dragon74 commented 1 week ago

/cc: @Madhu-1

black-dragon74 commented 1 week ago

@black-dragon74 changes looks good can you please add details to 2nd commit what is the exact problem and how it is fixed? and also did you try to test update and see everything works fine, please test bundle as well.

Updated the commit message. Yes I tested everything throughout, including the creation of new resources using kubebuilder create.

make bundle make bundle-validate make deploy make all make manifests have been tested and verified as well.

The deployment works as expected, verified by: make deploy and then kubectl -n csi-addons-system wait pods -l app.kubernetes.io/name=csi-addons --for=condition=Ready=True

I also checked output of kubectl -n csi-addons-system describe pods -l app.kubernetes.io/name=csi-addons; and everything was fine.

Anything else that I should validate?

Regards

Madhu-1 commented 4 days ago

@black-dragon74 changes looks good can you please add details to 2nd commit what is the exact problem and how it is fixed? and also did you try to test update and see everything works fine, please test bundle as well.

Updated the commit message. Yes I tested everything throughout, including the creation of new resources using kubebuilder create.

make bundle make bundle-validate make deploy make all make manifests have been tested and verified as well.

The deployment works as expected, verified by: make deploy and then kubectl -n csi-addons-system wait pods -l app.kubernetes.io/name=csi-addons --for=condition=Ready=True

I also checked output of kubectl -n csi-addons-system describe pods -l app.kubernetes.io/name=csi-addons; and everything was fine.

Anything else that I should validate?

Regards

Looks good we need to test the upgrade as well. upgrade using bundle (extra test need to be done) to make sure nothing breaks