search

csi-addons / kubernetes-csi-addons

CSI-Addons implementation and APIs for Kubernetes
Apache License 2.0
17 stars 36 forks source link

Implement EncryptionKeyRotation controllers #608

Closed black-dragon74 closed 2 months ago

black-dragon74 commented 3 months ago

This patch implements the sidecar service for EncryptionKeyRotation and registers it

A new option is added to csi-addons test tool to test the EncryptionKeyRotation operation

black-dragon74 commented 3 months ago

Note to reviewer: This PR will cover everything related to implementing EncryptionKeyRotation.

I have separated changes into separate commits to make it easy to review. I will squash all the commits before merging.

Regards

black-dragon74 commented 2 months ago

Note: This PR has been rebased to https://github.com/black-dragon74/kubernetes-csi-addons/tree/migrate-go3 as kubebuilder (latest version) doesn't allow creation of resources with old layout.

Once https://github.com/csi-addons/kubernetes-csi-addons/pull/606 is merged, I will rebase it with main.

Regards

nixpanic commented 2 months ago

@black-dragon74 quite a few conflicts need to be addressed now :disappointed:

black-dragon74 commented 2 months ago

@black-dragon74 quite a few conflicts need to be addressed now 😞

I was expecting it 😂 . Taking a look

Regards

black-dragon74 commented 2 months ago

I have tested the csi-addons tool along with the controllers for key rotation. Everything works as expected. The support for RWX volumes shall be added later (see commit msg).

Regards

black-dragon74 commented 2 months ago

@black-dragon74 please fix the CI issue

It (git diff) is failing as the protoc has been updated to 3.20.2 and the code in the current main branch uses 3.19.x

IG this is expected.

Madhu-1 commented 2 months ago

@black-dragon74 please fix the CI issue

It (git diff) is failing as the protoc has been updated to 3.20.2 and the code in the current main branch uses 3.19.x

IG this is expected.

We can't merge a PR if CI fails, please update the CI version here https://github.com/csi-addons/kubernetes-csi-addons/blob/1a1dd5f6e469f99eeb2f55ad18069f83698657c7/.github/workflows/test-golang.yaml#L27 to match the expectation

black-dragon74 commented 2 months ago

It would be much easier to review if you can split this huge commit into several ones:

It was exactly like that (split into 7 commits). I will split it again :( Update: Done @nixpanic

  • documentation + example under doc/ directory (missing completely)

Will add it in a future PR.

nixpanic commented 2 months ago

@mergifyio rebase

mergify[bot] commented 2 months ago

rebase

✅ Branch has been successfully rebased