search

csi-addons / volume-replication-operator

Apache License 2.0
16 stars 23 forks source link

Remove unnecessary type conversion in the reconciler result #125

Closed humblec closed 2 years ago

humblec commented 2 years ago

Signed-off-by: Humble Chirammal hchiramm@redhat.com

humblec commented 2 years ago

Cc @ShyamsundarR @iamniting

humblec commented 2 years ago

Cc @sp98 @Madhu-1

humblec commented 2 years ago

@Madhu-1 comments are addressed, can you please rereview ?

humblec commented 2 years ago

@Madhu-1 can you review this PR ?

Madhu-1 commented 2 years ago

@Madhu-1 can you review this PR ?

@humblec https://github.com/csi-addons/volume-replication-operator/pull/125#discussion_r746442837 is not addressed PTAL.

humblec commented 2 years ago

@Madhu-1 can you review this PR ?

@humblec #125 (comment) is not addressed PTAL.

@Madhu-1 addressed that too. ptal.. thanks

humblec commented 2 years ago

@Madhu-1 can you please revisit this PR , looks like tests need approval to be run :)

humblec commented 2 years ago

HuH..

 Error: ineffectual assignment to client (ineffassign)
  Error: ineffectual assignment to client (ineffassign)
  Error: ineffectual assignment to client (ineffassign)

  Error: issues found

Dont even say which line is that :)

humblec commented 2 years ago

@Madhu-1 should be good now. ptal.. thanks.