search

csi-addons / volume-replication-operator

Apache License 2.0
16 stars 23 forks source link

Init the CRDs and the controllers #2

Closed raghavendra-talur closed 3 years ago

raghavendra-talur commented 3 years ago

This commit is the only scaffolding required for the

raghavendra-talur commented 3 years ago

@Madhu-1 @iamniting @umangachapagain

This PR is very bare bones and the only thing to check is the domain(subdomain) names used for the resources. I would like to get this merged first so that we can discuss the CRD fields in the next PR.

Madhu-1 commented 3 years ago

@leseb @jarrpa tagging you guys to help with the review

raghavendra-talur commented 3 years ago

@Madhu-1 @umangachapagain @sp98 This force push has the following changes:

  1. The domain is storage.openshift.io. This is the closest we have in the openshift domain that is outside of the ocs group but still storage related.
  2. The group is replication. As the domain is storage I think we don't need to state volume replication again. It is understood.
  3. Now the objects are of the format kind.group.domain.
  4. I have created #7 to address most of the review suggestions by @umangachapagain .
Madhu-1 commented 3 years ago

@Madhu-1 @umangachapagain @sp98 This force push has the following changes:

  1. The domain is storage.openshift.io. This is the closest we have in the openshift domain that is outside of the ocs group but still storage related.

:+1:

  1. The group is replication. As the domain is storage I think we don't need to state volume replication again. It is understood.
  2. Now the objects are of the format kind.group.domain.
  3. I have created #7 to address most of the review suggestions by @umangachapagain .