search

csi-addons / volume-replication-operator

Apache License 2.0
16 stars 23 forks source link

vr: Update status of the volumereplication object #43

Closed iamniting closed 3 years ago

iamniting commented 3 years ago

Update status of volume replication CR

Signed-off-by: Nitin Goyal nigoyal@redhat.com

iamniting commented 3 years ago

@iamniting can you be more specific from what state we are changing to what each operation, a table to cover all operations like (primary, resync, and secondary) might be helpful to understand it.

Maybe then we can add a phase also to the status to differentiate b/w actual state and the reconcile state to clear all these doubts.

Madhu-1 commented 3 years ago

@iamniting can you be more specific from what state we are changing to what each operation, a table to cover all operations like (primary, resync, and secondary) might be helpful to understand it.

Maybe then we can add a phase also to the status to differentiate b/w actual state and the reconcile state to clear all these doubts.

adding this table for more clarity helps https://github.com/kube-storage/volume-replication-operator/pull/43#pullrequestreview-611885593

iamniting commented 3 years ago

@iamniting can you be more specific from what state we are changing to what each operation, a table to cover all operations like (primary, resync, and secondary) might be helpful to understand it.

Maybe then we can add a phase also to the status to differentiate b/w actual state and the reconcile state to clear all these doubts.

adding this table for more clarity helps #43 (review)

ImageState StatusPhase StatusState
Primary Replicating/Failed/Replicated Unknown/PrevState/Primary
Secondary Replicating/Failed/Replicated Unknown/PrevState/Secondary
Resync Replicating/Failed/Replicated Unknown/PrevState/Resynced

The unknown state will be for the newly created CR. PrevState will be for the edited CR it will reflect PrevState until a new state is acheived. Will mark the state as ImageState if no failures and achieved the state.