search

csi-addons / volume-replication-operator

Apache License 2.0
16 stars 23 forks source link

Rename VolRep `Spec.ImageState` to `Spec.VolumeState` #46

Closed ShyamsundarR closed 3 years ago

ShyamsundarR commented 3 years ago

Currently the spec names the state of the volume as imageState. Image gives the connotation that the volume is backed by an image, which is true for block based RWO providers, it hence maybe better to refer to this as volumeState instead to stay generic.

vdeenadh commented 3 years ago

Another suggestion for imageState is replicationState, as defined in the VolRep SHIM: https://pkg.go.dev/github.com/shyamsundarr/volrep-shim-operator@v0.0.0-20210310121354-2f9f9b83efb6/api/v1alpha1?utm_source=gopls#ReplicationState

Madhu-1 commented 3 years ago

@vdeenadh Thanks for the suggestion!