csi-addons / volume-replication-operator

Apache License 2.0
17 stars 23 forks source link

empty `apiGroup` in the VolumeReplication CR causes error #56

Open sp98 opened 3 years ago

sp98 commented 3 years ago

2021-03-25T06:48:07.190Z ERROR controller-runtime.manager.controller.volumereplication Reconciler error {"reconciler group": "replication.storage.openshift.io", "reconciler kind": "VolumeReplication", "name": "pvc-volumereplication", "namespace": "rook-ceph", "error": "VolumeReplication.replication.storage.openshift.io \"pvc-volumereplication\" is invalid: spec.dataSource.apiGroup: Invalid value: \"null\": spec.dataSource.apiGroup in body must be of type string: \"null\""}

rexagod commented 3 years ago

Do you mean the VolumeReplication CR? Also, can you paste in the command that showed you this log? I checked the operator pods and some other pods after setting apiGroup to "" but can't seem to find this error message, although I think it's worth mentioning that ever since I did that, the status is stuck at Replicating as you can see below.

Name:         pvc-volumereplication
Namespace:    default
Labels:       <none>
Annotations:  <none>
API Version:  replication.storage.openshift.io/v1alpha1
Kind:         VolumeReplication
Metadata:
  Creation Timestamp:  2021-04-05T02:09:42Z
  Finalizers:
    replication.storage.openshift.io
  Generation:  2
  Managed Fields:
    API Version:  replication.storage.openshift.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:dataSource:
          .:
          f:kind:
          f:name:
        f:replicationState:
        f:volumeReplicationClass:
    Manager:      kubectl-client-side-apply
    Operation:    Update
    Time:         2021-04-05T02:09:42Z
    API Version:  replication.storage.openshift.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        f:dataSource:
          f:apiGroup:
    Manager:      kubectl-edit
    Operation:    Update
    Time:         2021-04-05T17:29:08Z
    API Version:  replication.storage.openshift.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:finalizers:
          .:
          v:"replication.storage.openshift.io":
      f:status:
        .:
        f:lastCompletionTime:
        f:lastStartTime:
        f:message:
        f:state:
    Manager:         manager
    Operation:       Update
    Time:            2021-04-05T17:45:43Z
  Resource Version:  150667
  Self Link:         /apis/replication.storage.openshift.io/v1alpha1/namespaces/default/volumereplications/pvc-volumereplication
  UID:               ee4a3443-f48c-44f9-bc42-924bdd2aafb8
Spec:
  Data Source:
    API Group:               
    Kind:                    PersistentVolumeClaim
    Name:                    rbd-pvc
  Replication State:         primary
  Volume Replication Class:  rbd-volumereplicationclass
Status:
  Last Completion Time:  2021-04-05T17:45:43Z
  Last Start Time:       2021-04-05T17:29:08Z
  Message:               volume is marked primary
  State:                 Replicating
Events:                  <none>
Madhu-1 commented 3 years ago

Looks like this is not happening, @sp98 can you please verify it once?