Closed iamniting closed 3 years ago
The commit message is not descriptive, Can you please add more details and also please squash the commits where it's not required.
Please paste the output from the kube CLI if required
We can not create a CR with an invalid state
$ oc create -f file.yaml
The VolumeReplication "vr1" is invalid: spec.replicationState: Unsupported value: "primar": supported values: "primary", "secondary", "resync"
Now it will print some informational field also
$ oc get volumereplication
NAME AGE REPLICATIONSTATE STATUSSTATE MESAGE
vr1 7s primary
We can use vr
to get the volumereplication CR's
$ oc get vr
NAME AGE REPLICATIONSTATE STATUSSTATE MESAGE
vr1 39s primary
what do you think?
Like the idea and made changes
will merge this one once we branch out or create a fork for downstream
@mergifyio rebase
Command rebase
: success
Branch has been successfully rebased
$ oc get vrc
NAME PROVISIONER
vrc rook-ceph.rbd.csi.ceph.com
$ oc get vr
NAME AGE VOLUMEREPLICATIONCLASS PVCNAME DESIREDSTATE CURRENTSTATE
vr1 23s vrc pvc1 primary
@mergifyio refresh
Command refresh
: success
Pull request refreshed
Looks like i need to revisit mergify rules , Merging this one manually
@mergifyio refresh
Command refresh
: success
Pull request refreshed
As part of the PR made below changes to the custom resource
Signed-off-by: Nitin Goyal nigoyal@redhat.com