csi-addons / volume-replication-operator

Apache License 2.0
16 stars 23 forks source link

Make some enhancements to the volume replication CR #77

Closed iamniting closed 3 years ago

iamniting commented 3 years ago

As part of the PR made below changes to the custom resource

Signed-off-by: Nitin Goyal nigoyal@redhat.com

Madhu-1 commented 3 years ago

The commit message is not descriptive, Can you please add more details and also please squash the commits where it's not required.

Madhu-1 commented 3 years ago

Please paste the output from the kube CLI if required

iamniting commented 3 years ago

We can not create a CR with an invalid state

$ oc create -f file.yaml 
The VolumeReplication "vr1" is invalid: spec.replicationState: Unsupported value: "primar": supported values: "primary", "secondary", "resync"

Now it will print some informational field also

$ oc get volumereplication
NAME   AGE   REPLICATIONSTATE   STATUSSTATE   MESAGE
vr1    7s    primary                          

We can use vr to get the volumereplication CR's

$ oc get vr
NAME   AGE   REPLICATIONSTATE   STATUSSTATE   MESAGE
vr1    39s   primary                          
iamniting commented 3 years ago

what do you think?

Like the idea and made changes

Madhu-1 commented 3 years ago

will merge this one once we branch out or create a fork for downstream

Madhu-1 commented 3 years ago

@mergifyio rebase

mergify[bot] commented 3 years ago

Command rebase: success

Branch has been successfully rebased

iamniting commented 3 years ago
$ oc get vrc
NAME   PROVISIONER
vrc    rook-ceph.rbd.csi.ceph.com
$ oc get vr
NAME   AGE   VOLUMEREPLICATIONCLASS   PVCNAME   DESIREDSTATE   CURRENTSTATE
vr1    23s   vrc                      pvc1      primary        
Madhu-1 commented 3 years ago

@mergifyio refresh

mergify[bot] commented 3 years ago

Command refresh: success

Pull request refreshed

Madhu-1 commented 3 years ago

Looks like i need to revisit mergify rules , Merging this one manually

Madhu-1 commented 3 years ago

@mergifyio refresh

mergify[bot] commented 3 years ago

Command refresh: success

Pull request refreshed