search

csi-lk / aws-ses-local

Local Amazon Simple Email Service Server
MIT License
23 stars 10 forks source link

Allow text or html or both, but not neither #10

Closed camjackson closed 6 years ago

camjackson commented 6 years ago

I originally made a PR for this change against jdelibas' fork, seeing as that one has a Dockerfile. But there's been no response there, and it seems you've made changes in the last few months, so I was hoping you might take a look at this 🙂

Details copied over from the other PR:

Currently aws-ses-local requires that both html and text bodies be present.

If you try manually sending a request to the real SES, you'll find that it does allow you to omit one of them (as long as you have the other).

This PR makes it so that requests succeed as long as at least one of the two has been given.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+2.6%) to 88.095% when pulling 09f12676c4dda45a9ac0e38868ac4b2b9fe29f28 on camjackson:allow-text-or-html into 1381c029d8ed5f22a00de559544e225af0b81d52 on Si1kIfY:master.

csi-lk commented 6 years ago

Looks good, thanks for the PR, i'll version a new npm release hopefully tonight