search

csicar / Ning

Network-Scanner for Android
216 stars 35 forks source link

Improve device type detection #42

Closed mueller-ma closed 3 years ago

mueller-ma commented 3 years ago

See #37

csicar commented 3 years ago

Yeah. That's a great idea! I'd be happy to get that merged. I know it looks a little overblown right now, but I think this structure makes sense, when the device detection gets more complicated.

mueller-ma commented 3 years ago

Sure, sounds good. I give it a try.

mueller-ma commented 3 years ago

I pushed some commits. The default icon now shows a phone, a laptop and a watch, so it's more like "some device". The laptop icon is now only used for computers (currently Dell and MSI).

csicar commented 3 years ago

Oh wow! You also implemented the device type display in the details page. That's awesome!

csicar commented 3 years ago

Sound good to me :+1

I pushed some commits. The default icon now shows a phone, a laptop and a watch, so it's more like "some device". The laptop icon is now only used for computers (currently Dell and MSI).

Yeah, that's a good idea. I'll also add Lenovo to that list later

csicar commented 3 years ago

Perfect! Thanks for the PR! I'll merge it right away :)