Add build job with GitHub Actions

csicar / Ning

Network-Scanner for Android

216 stars 35 forks source link

Add build job with GitHub Actions #44

Closed mueller-ma closed 3 years ago

mueller-ma commented 3 years ago

I saw you're using Gitlab CI, but only on master, not on PRs. This PR adds a build job on GitHub Actions.

csicar commented 3 years ago

Yeah.. I got annoyed by that as well. It's fixed now :)

csicar commented 3 years ago

I actually prefer gitlab ci for 2 reasons:

It automatically syncs with Gitlab, meaning developers can use the platform they prefer
I can run my own CI Runner

TBH I haven't used Github Actions much, so if I'm missing something or GitHub Actions also offers running your own runners, I'd be happy to give it a try

mueller-ma commented 3 years ago

GitHub Actions also offers running your own runners.

You can, but isn't a runner provided by GitHub or Gitlab better? If using your own runner, anyone could open a PR and run untrusted code on your node.

csicar commented 3 years ago

Yes, that's right. Luckily the runners are adequately locked down, so that ci jobs should never escape the sandbox. It would still be possible to run a crypto miner, but that should be easy enough to stop

mueller-ma commented 3 years ago

Ok, so feel free to close this PR.