search

csicar / Ning

Network-Scanner for Android
216 stars 35 forks source link

some devices are not detected #97

Open SuperITMan opened 2 years ago

SuperITMan commented 2 years ago

Hey,

First of all, thanks for your application which is a nice OSS alternative to Fing!

Unfortunately, comparing the results of both applications, I remarked that some of my devices are missing when using Ning, comparing to Fing.

Ning

drawing

Fing

drawing

Missing devices

Would you have any idea on how to solve this? 😊

If I can provide more details, please do not hesitate.

csicar commented 2 years ago

First of all, thanks for your application which is a nice OSS alternative to Fing!

Thank you :)

Would you have any idea on how to solve this? blush

Ning uses (among other, faster techniques) a normal ICMP ping to find out what devices are online.

I could see two reasons for issues with the devices:

  1. The network is slow and pings need longer than the set timeout of 1s (https://github.com/csicar/Ning/blob/master/app/src/main/java/de/csicar/ning/scanner/PingScanner.kt#L26)
  2. The devices to not respond to ping requests.

If you don't mind, could you try to ping the missing devices manually? For example, you could run ping 192.168.2.177 using the termux app.

SuperITMan commented 2 years ago

Hey @csicar

Sorry for the delay.

Indeed, I tried to ping my MacBook with the command ping 192.168.2.177 and I got 100% packet loss. Then I tried from a Windows computer to ping the MacBook and same result...

It seems that some devices are not "pingable".

I guess that FIng uses other techniques to detect devices.

csicar commented 2 years ago

Does your MacBook have an open port? In that case #100 might solve this as well.

Also: Ning now a custom mDNS / bonjour scanner to find devices independent of ping requests. This might be hard to test for you, but do you know if you MacBook responds to mDNS requests?

Flexmaen commented 1 year ago

ning_test_1b ning_test_2b

I can confirm the same issue.

Also I have a comparison with Fing here: In the example here we see that a HP Pavillion Laptop is missing in the list in Ning. Also the IP Adress 192...1 is revealed as Fritzbox 7590 in Fing while it is shown but not detected in Ning. For the cellphones in the Network Ning shows the vendor while Fing shows the exact device.