search

csingley / ibflex

Python parser for Interactive Brokers Flex XML statements
MIT License
87 stars 43 forks source link

Field levelOfDetail was added to CashTransaction #23

Closed titov-vv closed 3 years ago

titov-vv commented 3 years ago

Hi Christopher,

One of my users faced this field in CashTransaction so I added it here. Unfortunately I can't add a test as I don't have a copy of transaction itself (but I'm sure that this patch helped to resolve the problem). I assume this field has the same meaning as for Trade - so I may copy test from Trade from CashTransaction if you wish, but I think it is safe to accept this pull request without test update.

Vlad

csingley commented 3 years ago

I don't think there's much point in adding a test with made-up data. Just, you know, try to capture real-world data as much as you can so that meaningful tests can be put in place. It's hard with financial data; nobody wants to give it to you. I wonder why that is.