search

csingley / ibflex

Python parser for Interactive Brokers Flex XML statements
MIT License
87 stars 43 forks source link

Update OptionAction, add Buy type #35

Closed particlep closed 3 years ago

particlep commented 3 years ago

... date="2011-08-05" transactionType="Buy" quantity="100" ...

csingley commented 3 years ago

Hey thanks for the add. Did you try running the test you're checking in here?

You've set <OptionEAE assetCategory="STK">, but then on the test you say self.assertEqual(instance.assetCategory, enums.AssetClass.OPTION), which of course fails.

I very much appreciate checking in tests that exercise the code you're adding. Do me a favor, make sure the tests pass (either with make test or simply python tests/test_types.py), and then send along the PR. Thanks.

particlep commented 3 years ago

Hi,

Sorry about that.

csingley commented 3 years ago

@particlep added enums.OptionAction.BUY w/ test