search

csingley / ibflex

Python parser for Interactive Brokers Flex XML statements
MIT License
87 stars 43 forks source link

Added Paxos attributes to class CashReportCurrency #59

Closed agusalex closed 1 year ago

agusalex commented 1 year ago
csingley commented 1 year ago

Thanks for the Paxos modelling. I'm good with the mixed Enum inheritance; the added functionality would be handy, and it seems harmless.

But why you got to go messing with mi tabs, carnale?? Let me guess - it's a black thing; I wouldn't understand. A lecture delivered from upstream, using you as a delivery vector, about how any whitespace convention other than their own leads to VCS confusion and diffs that make the baby Linus cry.

These classes are just pure interface definition code; we'll probably only ever touch each class attribute once, and then leave it alone forever after. So this diff right here is bloated with a bunch of extra lines that just harms source code readability, without unlocking any of the benefits claimed by proponents of this fascist regime.

End of rant. I can't be mad at you - you're clearly awesome, and making this codebase better - but my man, take back control of your text editor. A linter is a good servant, but a poor master. You let that thing off the leash, and now it's pooping on the floor.