FIGS Fixes - Githubissues

mepland commented 1 year ago

Added SKompiler integration, which required the new n_features_in_ member variable.
- Note the demo FIGS model currently requires https://github.com/mepland/SKompiler/tree/fixes to run which fixes a bug in SKompiler. TLDR SKompiler was not letting trees run if they use less than all the available features, like the demo FIGS tree 0.
Fixed bug in n_features
n_features = np.unique(features[np.where( 0 < features )]).size
n_features = np.unique(features[np.where( 0 <= features )]).size
Improved markdown comments in FIGS_viz_demo.ipynb

mepland commented 1 year ago

csinva commented 1 year ago

This is awesome! I'll bump the version once Skompiler does to include the change :)

mepland commented 1 year ago

@csinva thanks! Skompiler bumped their version. After imodels is bumped I can make a new PR with the notebook cleaned up and those paths removed.

csinva commented 1 year ago

Ah sorry for the slowness on this, somehow missed the notification...

Just bumped the version!

csinva / imodels