search

csinva / imodels

Interpretable ML package 🔍 for concise, transparent, and accurate predictive modeling (sklearn-compatible).
https://csinva.io/imodels
MIT License
1.35k stars 120 forks source link

'BoostedRulesClassifier' object has no attribute 'complexity_' #147

Closed yinweisu closed 1 year ago

yinweisu commented 1 year ago

After imodel being updated to 1.3.8, we've got the error msg 'BoostedRulesClassifier' object has no attribute 'complexity_'. Wonder is it removed or renamed? It is generally better to keep public apis/attributes unchanged during minor releases, any plan to add it back?

csinva commented 1 year ago

Sorry about that! This was a mistake -- will add it back and rebump the version today.

csinva commented 1 year ago

Just fixed and bumped the version -- let me know if the error is still present!

yinweisu commented 1 year ago

So I tried 1.3.9 and we have another problem: AttributeError: 'BoostedRulesClassifier' object has no attribute 'estimator'

csinva commented 1 year ago

Sorry about that, seems like estimator wasn't being set for certain sklearn versions...just pushed a fix and bumped to 1.3.10.

yinweisu commented 1 year ago

Is 1.3.10 released in pypi? Can't find it yet

csinva commented 1 year ago

Should be there now!