search

csinva / imodels

Interpretable ML package 🔍 for concise, transparent, and accurate predictive modeling (sklearn-compatible).
https://csinva.io/imodels
MIT License
1.34k stars 119 forks source link

Inconsistent types for RuleFit._extract_rules() #173

Closed marcjulianschwarz closed 1 year ago

marcjulianschwarz commented 1 year ago

The method _extract_rules() in the class RuleFit has List[Rule] as type annotation for the return value. However it returns the result of extract_rulefit() which returns a list of strings.

csinva commented 1 year ago

Thanks for catching this! Just fixed in 04ecbd8