Follow up #184 - print(estimator)

csinva / imodels

Interpretable ML package 🔍 for concise, transparent, and accurate predictive modeling (sklearn-compatible).

https://csinva.io/imodels

MIT License

1.34k stars 119 forks source link

Closed jckkvs closed 7 months ago

jckkvs commented 11 months ago

Add tests ,test_fit_estimators.py & test_print.py

I have made corrections to the incorrect part in the previous pull request.

csinva commented 11 months ago

Thanks for all this hard work! Could you resolve the conflicts with master before I merge it in?

jckkvs commented 11 months ago

Sorry for the late reply. I will fix it in a while

jckkvs commented 11 months ago

I have checked the conflicts. However, this conflicts is an important change that allows you to print (estimator) even before fitting the estimator.

jckkvs commented 10 months ago

@csinva

Sorry for being late. I have resolved the conflict.

csinva commented 10 months ago

Are the tests passing for you?

When I run them on this PR, I get issues with the line self.estimator = estimator in figs.py.
After commenting that line, many tests pass, but the tests in test_print.py and test_fit_estimators.py still fail.

jckkvs commented 10 months ago

Sorry for the delayed response. Indeed, many tests are not passing. I am currently reviewing the source code bit by bit