search

csinva / imodels

Interpretable ML package 🔍 for concise, transparent, and accurate predictive modeling (sklearn-compatible).
https://csinva.io/imodels
MIT License
1.34k stars 119 forks source link

RuleFit parameter `sample_fract` seems to do nothing #200

Open Feelx234 opened 5 months ago

Feelx234 commented 5 months ago

Dear maintainers of imodel,

Thank you very much for creating and maintaining this library. Looking at the source code of RuleFit, I find that the sample_fract parameter/attribute is unused. It is set in the constructor and then never used again. I also searched through the source files and could not find a meaningful use of sample_fract . It is set in other classes such as StableLinear and FPLasso but not used there either. Also i checked against TransformerMixin and ClassifierMixin they also don't seem to use the sample_fract parameter.

It seems there is an sample_frac_ in line 37 in extract.py https://github.com/csinva/imodels/blob/6efaa9075df89a8750fe1125cff1010b65f1f2b4/imodels/util/extract.py#L36-L39 But it seems to be unaffected by RuleFit.sample_fract.

Is this intended behavior? Or is it planned, that this parameter is used in the future/ was used in the past?

Thank you very much for clarifying