csirac2 / snazzer

btrfs snapshotting and backup system offering snapshot measurement, transport and pruning.

BSD 2-Clause "Simplified" License

89 stars 9 forks source link

Install zipped manpages to $INSTALL_PREFIX/share/man #35

Closed florianjacob closed 7 years ago

florianjacob commented 7 years ago

It would ease creating and maintaining snazzer packages if make install would also install the manpages to $INSTALL_PREFIX/share/man, preferably gzipped.

Refer to the AUR package shell script to see what package maintainers are currently doing.

I don't know how to achieve that, though. Add another find statement to make install / uninstall somehow?

This was requested by maintainer jhass @ https://aur.archlinux.org/packages/snazzer-git/

csirac2 commented 7 years ago

INSTALL_PREFIX should never have been a full path to bin/ ... to avoid another similar mistake I'm doing this next fix as a PR & inviting code review ;-)

Changing INSTALL_PREFIX semantics is a breaking change, so a heads up to @jhass would be good

florianjacob commented 7 years ago

Let's do this. :+1:

florianjacob commented 7 years ago

I'll reach out to @jhass as soon as the PR is ready and coordinate the merge. I think he lives in UTC+1 as well, so we can probably figure something out to make the timeframe in which the build would break quite short.

csirac2 commented 7 years ago

Ready to go I think, will let you merge when ready.

florianjacob commented 7 years ago

36 works like charm! :sparkles: