Fix btrfs send -p arg usage incompatible w/btrfs-progs 4.11 onwards

csirac2 / snazzer

btrfs snapshotting and backup system offering snapshot measurement, transport and pruning.

BSD 2-Clause "Simplified" License

89 stars 9 forks source link

Fix btrfs send -p arg usage incompatible w/btrfs-progs 4.11 onwards #54

Closed csirac2 closed 7 years ago

csirac2 commented 7 years ago

Closes #53

florianjacob commented 7 years ago

Change looks well-done. 👍

I'm not sure how to reproduce it though, i.e. which snazzer commands to test. The test cases run through for me even without this change, while a raw btrfs send .snapshotz/B -p .snapshotz/A fails like @ntxy described it.

csirac2 commented 7 years ago

Sadly I haven't written tests for snazzer-receive yet - I can try to do this shortly but may struggle for time.

ntxy commented 7 years ago

Thank You for fixing this so superquickly! :)

florianjacob commented 7 years ago

@csirac2 Sorry! I mistook the test cases you adjusted for tests that already would cover this. 😉

@ntxy Excuse me that I'm not sure, but were you able to confirm this fixed your issue? In case you did not do or know this already, you should be able to install this version easily by modifying the PKGBUILD source line (saw your comment on the AUR package 😄):

source=("git+https://github.com/csirac2/snazzer.git#branch=53-fix-btrfs-progs-send-p-arg")

csirac2 commented 7 years ago

Thanks @rnkch - with that, I think I'll merge and call it 0.3. Cheers