csiro-coasts / emsarray

xarray extension that supports EMS model formats
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

Shoc datasets without depth coordinate throw errors #123

Closed mx-moth closed 8 months ago

mx-moth commented 9 months ago

SHOC datasets that do not have a depth coordinate throw an error in Convention.get_depth_name() which is correct, but this error bubbles up to Convention.get_all_depth_names() which is incorrect. This means that Shoc datasets that have been passed through Convention.ocean_floor() will not support Convention.select_variables(), for a specific failure case.

/ShocStandard/ShocSimple.get_all_depth_names() should not throw an error if there is no depth coordinate.