csiro-hydrogeology / pyela

Python package for Exploratory Lithology Analysis
Other
24 stars 5 forks source link

VisualizeDataProcess.lithology_layer_process is not data column independent #19

Open jmp75 opened 5 years ago

jmp75 commented 5 years ago

Reviewing / testing a contribution for pyvista use. Some of the code has hard coded use of 'x' and 'y' for column names expected in the data frame.

jmp75 commented 5 years ago

gi = GridInterpolation(easting_col='x', northing_col='y') is the problem line. Trying to design a unit test is complicated by the top entry function taking data paths as agruments. IO should be dealt with elsewhere.