search

csiro-robotics / InCloud

[IROS2022] Official repository of InCloud: Incremental Learning for Point Cloud Place Recognition, Published in IROS2022 https://arxiv.org/abs/2203.00807
https://ieeexplore.ieee.org/document/9981252
Other
37 stars 9 forks source link

AttributeError: false_positive_thresh #5

Closed lbhwyy closed 1 week ago

lbhwyy commented 7 months ago

In the code eval_singlesession.py, should the line 86 elif top1_world_dist > configs.eval.false_positive_thresh: be changed to elif top1_world_dist > false_pos_thresh?

Traceback (most recent call last): File "training/train_incremental.py", line 79, in eval_stats = evaluate(new_model, env_idx) File "/home/ros/deep_learning/Place_recognition/continual_PR/InCloud/eval/evaluate.py", line 26, in evaluate env_recall_1.append(eval_singlesession(model, d, world_thresh, false_pos_thresh, time_thresh)['Recall@1']) File "/home/ros/deep_learning/Place_recognition/continual_PR/InCloud/eval/eval_singlesession.py", line 86, in eval_singlesession elif top1_world_dist > configs.eval.false_positive_thresh: File "/home/ros/anaconda3/envs/minklocv2/lib/python3.8/site-packages/torchpack/utils/config.py", line 17, in getattr raise AttributeError(key) AttributeError: false_positive_thresh

Thunder-Volcano commented 4 months ago

I find the same problem and I think you are right. To implement successfully, 'configs.eval.' should be removed.