search

csirtgadgets / massive-octo-spice

DEPRECATED - USE v3 (bearded-avenger)
https://github.com/csirtgadgets/bearded-avenger-deploymentkit/wiki
GNU Lesser General Public License v3.0
227 stars 60 forks source link

cif-router init never stops trying #374

Closed giovino closed 8 years ago

giovino commented 8 years ago

in this loop cif-router will retry every five seconds indefinitely if the storage nodes are not available. 

[2015-12-09T04:29:27,535Z][30514][FATAL][CIF::Router:100]: unable to start router, no storage handle...
[2015-12-09T04:29:27,535Z][30514][WARN][main:189]: retrying in 5secs...
[2015-12-09T04:29:32,536Z][30514][DEBUG][CIF::Storage::ElasticSearch:102]: checking handle...
[2015-12-09T04:29:32,536Z][30514][INFO][CIF::Storage::ElasticSearch:103]: storage node: localhost:9200
[2015-12-09T04:29:32,540Z][30514][FATAL][CIF::Storage::ElasticSearch:112]: [NoNodes] ** No nodes are available: [http://localhost:9200], called from sub Search::Elasticsearch::Transport::try {...}  at /usr/share/perl5/Try/Tiny.pm line 81.

Should this timeout at some point?

giovino commented 8 years ago

this probably gets more complicated as monit will restart the service if a user stops it or the process stops itself.

wesyoung commented 8 years ago

should it? it was the other way around previously... is it harming something?

giovino commented 8 years ago

Harm might be strong, probably the only harm is the log filling up. I think what's hidden from the user is that there is a failure.

service cif-router restart -> OK.. things are working.. well not really. I guess the question is.. should a service start/restart with "OK" if it can't do the thing it should be doing.