search

csirtgadgets / massive-octo-spice

DEPRECATED - USE v3 (bearded-avenger)
https://github.com/csirtgadgets/bearded-avenger-deploymentkit/wiki
GNU Lesser General Public License v3.0
227 stars 62 forks source link

Ubuntu 16.04 support #412

Closed 0x4d4c closed 8 years ago

0x4d4c commented 8 years ago

I ported the easybutton.sh script to run under Ubuntu 16.04. Right now, everything seems to work (I'm still working on some Perl warnings though). Do you have some kind of test suite I can run against the CIF server to ensure that everything is fine indeed? Or is it sufficient to have the steps listed on the PlatformUbuntu page return reasonable outputs?

Hunlogo commented 8 years ago

Could you please share the updated easybutton.sh ? I already installed CIF on ubuntu 14.04 and will test it. if everything goes well I prefer 16.04 than 14.04 Thanks

giovino commented 8 years ago

We do not have a good test suite to test a live cif instance but there are two test scripts that end up testing a fair amount of features end to end (group_testing.sh and whitelist_testing.sh).

as for attempting to fully support ubuntu 16.04 our thoughts are something along the lines of:

  1. cp massive-octo-spice/hacking/platforms/ubuntu massive-octo-spice/hacking/platforms/ubuntu-16-04
  2. Update easybutton.sh to include support for 16.04 and point to ubuntu-16-04.sh

the two major things we can think of off the top of our head:

  1. will ElasticSearch 1.7 that ships work 16.04 work or should we continue to use ES 1.4 (easier to use 1.4, as it has been tested)
  2. What init.d stuff needs to be migrated to systemd
0x4d4c commented 8 years ago

Could you please share the updated easybutton.sh ?

I have a branch with my changes.

there are two test scripts that end up testing a fair amount of features end to end (group_testing.sh and whitelist_testing.sh)

Thanks, I'll try them out.

cp massive-octo-spice/hacking/platforms/ubuntu massive-octo-spice/hacking/platforms/ubuntu-16-04

Right now, I includes all changes in the existing ubuntu.sh as there is a lot of shared code. I'm planning to extract the common parts into something like a ubuntu_common.sh which can then be sourced by the version specific scripts.

will ElasticSearch 1.7 that ships work 16.04 work or should we continue to use ES 1.4

I'd opt for 1.7. There is something wrong the the init script in the ES version included in the standard Ubuntu repos though (wasn't able to find out what exactly yet), therefore, I use 1.7 provided by the ES repositories.

What init.d stuff needs to be migrated to systemd

Most of the stuff simply worked.

There are still one or two smaller (at least I hope they're small) issues I'm working on...

wesyoung commented 8 years ago

What were the results of running make test ?

wesyoung commented 8 years ago

closing this for now, wil work to make sure this is deployable on v3:

https://github.com/csirtgadgets/bearded-avenger/issues/63