csirtgadgets / massive-octo-spice

DEPRECATED - USE v3 (bearded-avenger)
https://github.com/csirtgadgets/bearded-avenger-deploymentkit/wiki
GNU Lesser General Public License v3.0
227 stars 62 forks source link

Expansion of multiple variables in fields #435

Closed tsmolka closed 8 years ago

tsmolka commented 8 years ago

I have noticed that field mappings are currently limited to only single variable for expansion. I would like to propose making this more generic and expand all variables.

wesyoung commented 8 years ago

neato, mind writing a simple test for this? help explain it a bit, make sure it doesnt' break if we make other changes?

eg: https://github.com/csirtgadgets/massive-octo-spice/blob/develop/src/t/20-openbl.t

maybe put the example rule in src/rules/example ?

tsmolka commented 8 years ago

Well, I have slightly rewritten the code so that variables are expanded in nested structures as well (e.g additional_data). I quickly tested the change and it seems OK.

wesyoung commented 8 years ago

rock on, ty!