search

csisc / OpenCitations-Bot

A bot to add citation data from OpenCitations to Wikidata
8 stars 2 forks source link

check missing? #19

Closed dpriskorn closed 3 years ago

dpriskorn commented 3 years ago

https://github.com/csisc/OpenCitations-Bot/blob/74d5983423ec8a0414f3289c97743e205bd685d8/OCtoWikidata.py#L50 Are you checking if the item already cites this work before appending? It seems like this could cause a lot of duplications in cited work

csisc commented 3 years ago

No, we are not using fast run. When I did the tests on the statements, I found that the WikibaseIntegrator library verifies the existence of the Wikidata Statement before adding it.