search

csisc / OpenCitations-Bot

A bot to add citation data from OpenCitations to Wikidata
8 stars 2 forks source link

move config in separate file #3

Closed dpriskorn closed 3 years ago

dpriskorn commented 3 years ago

https://github.com/csisc/OpenCitations-Bot/blob/1c1410ec1770f7b5e122acb5841b62233f2abfcf/OCtoWikidata.py#L6 it is risky to have the config in the same file as the rest of the code. someone might accidentally share their credentials

csisc commented 3 years ago

This is absolutely true. I can add a few lines where the user is asked to create a file where he puts his credentials. However, I think that this will only add to the complexity of the Python code without any added value.

dpriskorn commented 3 years ago

I agree that it adds complexity. Alternatively you could warn users in the Readme perhaps?

csisc commented 3 years ago

Done. Thank you for sharing this.