search

cskoglun / ciscodnacbackupctl

Other
15 stars 2 forks source link

Issue with retention only keeping 4 days of backups #12

Closed ryanbrunkhorst closed 2 years ago

ryanbrunkhorst commented 2 years ago

I've run the daemon with the following commands but it is only keeping 4 days worth of backups. I tried without the 'd' at first but then saw a Cisco forum post that had it included. Please advise if I'm making a mistake with the syntax. Thank you.

ciscodnacbackupctl daemon start --keep 31 ciscodnacbackupctl daemon start --keep 31d

robertcsapo commented 2 years ago

This should be similar to ciscodnacbackupctl purge --keep 31d What output do you get then? (Assuming you don't proceeded with the purge, during prompt)

https://github.com/cskoglun/ciscodnacbackupctl/blob/620ddd4b78fea0d8c666fd0cea52654a9b147bc3/ciscodnacbackupctl/__init__.py#L467

ryanbrunkhorst commented 2 years ago

output shows "No backup to delete"

ryanbrunkhorst commented 2 years ago

I currently have 6 days of backups so I tried with 5 days and it showed a single backup to delete. This appears to be working properly. I can give the daemon another try with 31 days and report back next week whether any of the 6 backups I have disappear.

fatman00 commented 2 years ago

We see the same issue. Have configured ciscodnacbackupctl daemon start --keep 90d. But only the last 3 days of backup are kept. Are there any way we can see what value the daemon is running with? Could we have stated it twice with a lower value?

ryanbrunkhorst commented 2 years ago

I can confirm over the weekend that all but 4 days worth of backups are kept when set to --keep 31d.

robertcsapo commented 2 years ago

@fatman00 @ryanbrunkhorst I think I've found the issue.

Could you test with latest version 0.2.8? pip install ciscodnacbackupctl==0.2.8

KamilDeszczka commented 2 years ago

I have uploaded it and backup lasts for last 6 days, so it looks promising, but per our policy, we have to keep them for 90 days, so final confirmation to be followed.

ryanbrunkhorst commented 2 years ago

I've updated to 0.2.8 from 0.2.7. I have 10 daily backups saved so I'll report back tomorrow if any disappear with --keep 31d.

ryanbrunkhorst commented 2 years ago

I see that I now have 11 backups so nothing was lost over night. Will have to see if the purge works correctly after day 31. Thanks for the fix.

robertcsapo commented 2 years ago

I've added the fix here. https://github.com/cskoglun/ciscodnacbackupctl/blob/6114a1186ef2cb399341b8a17ebcc468c48439db/ciscodnacbackupctl/cli.py#L33

Monitoring this until we merge it and close this issue 🙂

robertcsapo commented 2 years ago

@ryanbrunkhorst, @KamilDeszczka @fatman00 any issues (30+ days now)?

KamilDeszczka commented 2 years ago

Hello Robert,

From my end it looks promising. I can see that I am halfway there = 45 backups done so far.

Kind Regards, Kamil Deszczka

niedz., 24 kwi 2022 o 20:11 robertcsapo @.***> napisał(a):

@ryanbrunkhorst https://github.com/ryanbrunkhorst, @KamilDeszczka https://github.com/KamilDeszczka @fatman00 https://github.com/fatman00 any issues (30+ days now)?

— Reply to this email directly, view it on GitHub https://github.com/cskoglun/ciscodnacbackupctl/issues/12#issuecomment-1107890719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYIIO2IGZUMN67SMK6OWHDDVGWFDLANCNFSM5QKHTP4Q . You are receiving this because you were mentioned.Message ID: @.***>

-- Pozdrawiam Kamil Deszczka

KamilDeszczka commented 2 years ago

I an confirm that the backup did cross the 90 days, so script is working correctly! thank you for your help Robert!