search

cslarsen / jp2a

Converts jpg images to ASCII
GNU General Public License v2.0
782 stars 70 forks source link

jp2a fails to convert image, never returns #3

Open eribertomota opened 7 years ago

eribertomota commented 7 years ago

Hi!

I am very glad to see your return to jp2a development.

I will send some issues (this is the first) that I found packaging jp2a in Debian. This first bug is from Ubuntu and seems easy to fix. A copy from Launchpad[1]:

jp2a fails to convert some images, consuming all CPU for at least several hours. Sample image attached.

[1] https://bugs.launchpad.net/ubuntu/+source/jp2a/+bug/1252209

I will close the bug when upload the a new fixed package to Debian.

Thanks in advance.

Regards,

Eriberto

jp2a_fail

cslarsen commented 7 years ago

Thanks for the longtime package maintenance! Do you have a release window? Was 1.0.7 ever released on Debian?

eribertomota commented 7 years ago

2016-11-07 13:17 GMT-02:00 Christian Stigen Larsen <notifications@github.com

:

Thanks for the longtime package maintenance! Do you have a release window? Was 1.0.7 ever released on Debian?

Hi!

Thanks.

I need to package and upload a new version (1.0.8?) up to 18 December 2016 to be released in Debian Stretch. I will send a notice to all uptreams which I maintain packages. The 1.0.7 version was release in experimental, that is restrict and not commonly accessed by final users.

https://packages.qa.debian.org/j/jp2a.html

Cheers,

Eriberto

pedrormjunior commented 5 years ago

Still finding this same problem in an image 1 pixel high and 550 pixels wide. Running version 1.0.7 but the current version of the code on Github has the same problem. The image is the following (notice the yellowish line below): jp2a_bug

Why fixing this bug? It may seem strange someone wants to run jp2a in this kind of image, however, sometimes one is running jp2a in a batch of images along other commands. For example, in my case I found this bug using mutt, searching for expressions in the body of the messages. As I have defined jp2a to run automatically when opening a message, this bug stops the whole process of searching.

As @eribertomota have told, it seems straightforward to fix. In the worse case, just checking if the image is 1 pixel high and stopping even without output (this is not the ideal scenario but enough). That would be awesome if it get fixed and you provide a new release (1.0.8).

Thanks! Pedro

Talinx commented 4 years ago

I fixed this bug: https://github.com/Talinx/jp2a/tree/fixOnePixelHeight

The current behavior is that one line of characters will be output. This line seems to be empty regardless of the content of a 1 pixel high image, should therefore the height be set to 0?

eribertomota commented 4 years ago

Em seg., 3 de fev. de 2020 às 10:20, Christoph Raitzig < notifications@github.com> escreveu:

I fixed this bug: https://github.com/Talinx/jp2a/tree/fixOnePixelHeight

The current behavior is that one line of characters will be output. This line seems to be empty regardless of the content of a 1 pixel high image, should therefore the height be set to 0?

Hi Christoph,

I think that 0 is a good way.

Do you intend to maintain jp2a? @cslarsen is inactive.

Cheers,

Eriberto

Talinx commented 4 years ago

Em seg., 3 de fev. de 2020 às 10:20, Christoph Raitzig < notifications@github.com> escreveu: I fixed this bug: https://github.com/Talinx/jp2a/tree/fixOnePixelHeight The current behavior is that one line of characters will be output. This line seems to be empty regardless of the content of a 1 pixel high image, should therefore the height be set to 0? Hi Christoph, I think that 0 is a good way. Do you intend to maintain jp2a? @cslarsen is inactive. Cheers, Eriberto

Hello Eriberto,

Changed to 0 (and merged into master).

I would like to maintain jp2a!

Since I never maintained a project before, may I ask: Does my fork get the "official" repository or is there some transfer of ownership? Should I notify the maintainers of jp2a packages for distributions (like Debian/Ubuntu) of this change or new versions?

Best Regards, Christoph

eribertomota commented 4 years ago

Em segunda-feira, 3 de fevereiro de 2020, Christoph Raitzig < notifications@github.com> escreveu:

Em seg., 3 de fev. de 2020 às 10:20, Christoph Raitzig < notifications@github.com> escreveu: I fixed this bug: https://github.com/Talinx/jp2a/tree/fixOnePixelHeight The current behavior is that one line of characters will be output. This line seems to be empty regardless of the content of a 1 pixel high image, should therefore the height be set to 0? Hi Christoph, I think that 0 is a good way. Do you intend to maintain jp2a? @cslarsen https://github.com/cslarsen is inactive. Cheers, Eriberto

Hello Eriberto,

Changed to 0 (and merged into master).

I would like to maintain jp2a!

Since I never maintained a project before, may I ask: Does my fork get the "official" repository or is there some transfer of ownership? Should I notify the maintainers of jp2a packages for distributions (like Debian/Ubuntu) of this change or new versions?

You can use the current fork or make a new repository, adding all old versions and its tags. I was the maintainer in Debian. I made the package orphan because the upstream was inactive. If you adopt it, I will maintain again in Debian. Ubuntu will take it from Debian. See about other distros in repology.org. You can notify about the new repository. Debian will monitor about new versions.

Please, don't release 1.0.7 version. It was already released in the past and don't work.

Don't forget to put a Copyright line with your name and email address in main code.

Cheers,

Eriberto

Talinx commented 4 years ago

Em segunda-feira, 3 de fevereiro de 2020, Christoph Raitzig < notifications@github.com> escreveu: Em seg., 3 de fev. de 2020 às 10:20, Christoph Raitzig < @.***> escreveu: I fixed this bug: https://github.com/Talinx/jp2a/tree/fixOnePixelHeight The current behavior is that one line of characters will be output. This line seems to be empty regardless of the content of a 1 pixel high image, should therefore the height be set to 0? Hi Christoph, I think that 0 is a good way. Do you intend to maintain jp2a? @cslarsen https://github.com/cslarsen is inactive. Cheers, Eriberto Hello Eriberto, Changed to 0 (and merged into master). I would like to maintain jp2a! Since I never maintained a project before, may I ask: Does my fork get the "official" repository or is there some transfer of ownership? Should I notify the maintainers of jp2a packages for distributions (like Debian/Ubuntu) of this change or new versions? You can use the current fork or make a new repository, adding all old versions and its tags. I was the maintainer in Debian. I made the package orphan because the upstream was inactive. If you adopt it, I will maintain again in Debian. Ubuntu will take it from Debian. See about other distros in repology.org. You can notify about the new repository. Debian will monitor about new versions. Please, don't release 1.0.7 version. It was already released in the past and don't work. Don't forget to put a Copyright line with your name and email address in main code. Cheers, Eriberto

Made a 1.0.8 release. Thank you very much!

Best regards, Christoph

eribertomota commented 4 years ago

Em seg., 3 de fev. de 2020 às 20:15, Christoph Raitzig < notifications@github.com> escreveu:

Made a 1.0.8 release. Thank you very much!

Hi Christoph,

I just uploaded 1.0.8 version to Debian.

Please, go to the Tracker System[1] to know all things about jp2a in Debian. I would like to suggest to subscribe to package (in upper right corner) to receive news about bugs, uploads etc. The tracker page needs up to 48 hours to be updated.

[1] https://tracker.debian.org/pkg/jp2a

Thanks a lot for your work.

Cheers,

Eriberto

Talinx commented 4 years ago

Em seg., 3 de fev. de 2020 às 20:15, Christoph Raitzig < notifications@github.com> escreveu: Made a 1.0.8 release. Thank you very much! Hi Christoph, I just uploaded 1.0.8 version to Debian. Please, go to the Tracker System[1] to know all things about jp2a in Debian. I would like to suggest to subscribe to package (in upper right corner) to receive news about bugs, uploads etc. The tracker page needs up to 48 hours to be updated. [1] https://tracker.debian.org/pkg/jp2a Thanks a lot for your work. Cheers, Eriberto

Hello Eriberto,

I did not know about the tracker. I subscribed and keep an eye on it. Thank you!

Best regards, Christoph

eribertomota commented 4 years ago

Em qua., 5 de fev. de 2020 às 11:20, Christoph Raitzig < notifications@github.com> escreveu:

Em seg., 3 de fev. de 2020 às 20:15, Christoph Raitzig < notifications@github.com> escreveu: Made a 1.0.8 release. Thank you very much! Hi Christoph, I just uploaded 1.0.8 version to Debian. Please, go to the Tracker System[1] to know all things about jp2a in Debian. I would like to suggest to subscribe to package (in upper right corner) to receive news about bugs, uploads etc. The tracker page needs up to 48 hours to be updated. [1] https://tracker.debian.org/pkg/jp2a Thanks a lot for your work. Cheers, Eriberto

Hello Eriberto,

I did not know about the tracker. I subscribed and keep an eye on it. Thank you!

Best regards, Christoph

If you release a new version, tracker will notify me. See cewl here[1][2].

[1] https://tracker.debian.org/pkg/cewl [2] https://qa.debian.org/developer.php?login=eriberto%40debian.org

Cheers,

Eriberto