search

cslashm / ECPy

Apache License 2.0
38 stars 24 forks source link

switch from setuptools to poetry #29

Closed ledhed2222 closed 3 years ago

ledhed2222 commented 3 years ago

Heyo - I would love to eventually help you add type checking to this repo, as it will help us make the xrpl-py package better. As a first step, I recommend switching from setuptools to poetry as the latter makes it much easier IMO to manage development dependencies.

At the moment you have no dev dependencies, but once we add type checking etc we'll have a lot.

ledhed2222 commented 3 years ago

to be clear - the ultimate goal is to add type checking to ECPy - see https://github.com/XRPLF/xrpl-py

we're using you as a dependency and it would definitely be good to add.

ledhed2222 commented 3 years ago

ping

cslashm commented 3 years ago

Hi, Sorry, Didn't see the PR, I will review that ASAP Thanks for your contrib (and the ping)

cslashm commented 3 years ago

Ok let's try it.