search

cslmath / Champlain-Saint-Lambert-webwork-repo

A library of WeBWorK problems contributed by the Champlain Saint-Lambert math department
3 stars 4 forks source link

fix typos "Lorentz" -> "Lorenz" #30

Closed gabindu closed 3 years ago

gabindu commented 3 years ago

Lorenz curves are named after Max Otto Lorenz (1876-1959), see https://en.wikipedia.org/wiki/Max_O._Lorenz

Since some of the files might already be in use, the incorrect filenames were not changed, just the content.

maharper commented 3 years ago

Excellent.

Since some of the files might already be in use, the incorrect filenames were not changed, just the content.

They do something using redirecting in the OPL ie bad file name.pg is only a pointer to good file name.pg

I will investigate whether we can do this in the CPL. If so, we could redirect the bad file names to good file names which would solve the already in use problem. #31

gabindu commented 3 years ago

Honestly, I think that leaving "bad" filenames is a minor issue and shouldn't hold up content fixes. (But investigating #31 for the long term is of course desirable.)

maharper commented 3 years ago

@gabindu I should have been more clear. I wasn't suggesting delaying merging the pull request, just making a note that we could also rename the files later if we could use redirections in the CPL. The PR looks good to me.

mtitcombe commented 3 years ago

Looktz goodtz to me.