cslms / cs-server

Code School LMS main server
Other
4 stars 17 forks source link

Integrations tests and numeric questions tolerance tests #11

Closed vitornere closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #11 into dev will increase coverage by 0.42%. The diff coverage is 80.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #11      +/-   ##
==========================================
+ Coverage   66.52%   66.94%   +0.42%     
==========================================
  Files         143      146       +3     
  Lines        4496     4596     +100     
  Branches      437      443       +6     
==========================================
+ Hits         2991     3077      +86     
- Misses       1405     1419      +14     
  Partials      100      100
Impacted Files Coverage Δ
...c/codeschool/questions/numeric/tests/test_basic.py 100% <100%> (ø) :arrow_up:
src/codeschool/questions/numeric/factories.py 65.21% <20%> (-34.79%) :arrow_down:
src/codeschool/bricks/cards.py 78.26% <0%> (-21.74%) :arrow_down:
src/codeschool/__init__.py 45.45% <0%> (-11.69%) :arrow_down:
src/codeschool/lms/activities/views.py 35.71% <0%> (-6.4%) :arrow_down:
src/codeschool/questions/models.py 68% <0%> (-2.22%) :arrow_down:
...c/codeschool/lms/activities/tests/test_progress.py 68% <0%> (-1.24%) :arrow_down:
src/codeschool/lms/activities/tests/fixtures.py 72.09% <0%> (-0.64%) :arrow_down:
src/codeschool/questions/admin.py 100% <0%> (ø) :arrow_up:
src/codeschool/lms/listings/bricks.py 66.66% <0%> (ø) :arrow_up:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45b8b2a...e374d43. Read the comment docs.

fabiommendes commented 7 years ago

Alguns comentários sobre os testes:

Aceitei o PR, mas tem vários probleminhas. Tentem fazer PR mais focados que fica mais fácil de revisar. Organizem por funcionalidade e não por sprint.