search

csmart / ansible-role-virt-infra

Define and manage guests and networks on a KVM host with Ansible
GNU General Public License v3.0
67 stars 48 forks source link

Support for Kali Linux #58

Closed perunslava closed 2 years ago

csmart commented 2 years ago

Hi @perunslava, thanks for the pull request to gain support for Kali. I've looked at the way we implement this currently, and rather than adding a new file for Kali from Debian, I've re-worked the code to support families instead. This way Kali will automatically load the Debian variables. If Kali deviates enough from Debian, we can then add the file, but currently it's identical.

With this approach, we can automatically support other variants as well.

I have tested this on Kali and it works for me. If you want to test this yourself and let me know what you think, there's a separate PR here https://github.com/csmart/ansible-role-virt-infra/pull/59

Cheers, -c

perunslava commented 2 years ago

Your approach is better than mine. I am closing my PR.