search

csmart / ansible-role-virt-infra

Define and manage guests and networks on a KVM host with Ansible
GNU General Public License v3.0
67 stars 48 forks source link

Variables set in defaults-set.yml not used #69

Closed jwerak closed 1 year ago

jwerak commented 1 year ago

Variables virt_infra_architecture and virt_infra_domainname are checked and defined only in file defaults-set.yml.

Is this used somewhere else later in pipeline, or can this file be safely removed?

csmart commented 1 year ago

Hi @jwerak, thanks for reporting this. You're right they're only used in default-set.yml I think because I was anticipating supporting running VMs of architectures on a host (for example, letting you emulate an ARM machine on an x86_64 machine). I'd be happy to remove these and just default the variable when needed, if we enable support in the future. Cheers!

jwerak commented 1 year ago

Hi, here is the PR: https://github.com/csmart/ansible-role-virt-infra/pull/70

csmart commented 1 year ago

Thanks! I've merged it in.