search

csmberkeley / csm_web

Web applications for CS Mentors.
https://scheduler.csmentors.org/
MIT License
15 stars 10 forks source link

Student drop modal text overflow in small windows #451

Open joshualiao opened 1 year ago

joshualiao commented 1 year ago

Can't check "blacklist" when you try to ban a student, specifically in a restricted course. Should probably be removing them off the whitelist?

Reproduce: Add a student to a restricted course. Try to remove them by pressing red x. Blacklist window shows up; can't select checkbox to ban.

aaudreywu commented 1 year ago

Have you tried clicking these buttons first before checking "blacklist"? screen_shot_2023-10-30_at_7 51 08_pm_720

joshualiao commented 1 year ago

Maybe I have something imported wrong locally, if anyone else can reproduce? Specifically, I do this:

in admin/scheduler/course, turn CSM16A into a restricted course and save. Add a student to CSM16A as a coordinator. Press the red "x" to remove them.

For me, I get the following: https://github.com/csmberkeley/csm_web/assets/90676487/11b01fbb-2385-407e-95bc-49cfbe0c25a8 And the blacklist checkbox is not selectable. Curiously, in a non-restricted course, the same thing occurs, but with the ban option that is not selectable instead.

smartspot2 commented 9 months ago

I can't reproduce exactly what you're talking about, but for a small window, the modal does have vertical text overflow, which prevents the user from seeing anything that flows past the bottom of the window (see below). Adding a scrollbar upon overflow would remedy this issue.

image