csmith-project / creduce

C-Reduce, a C and C++ program reducer
Other
1.25k stars 123 forks source link

Compatibility for LLVM 11 #240

Closed jmperez-et closed 2 years ago

jmperez-et commented 2 years ago

This MR relies on berolinux changes for LLVM 10 support and adds further changes to to LLVM 11.

eeide commented 2 years ago

Thank you for your contribution!

Do you know if your changes are different than those on the existing llvm-11.0 branch? https://github.com/csmith-project/creduce/tree/llvm-11.0

jmperez-et commented 2 years ago

Hi Eric,

My MR includes the unmodified commit from berolinux in MR #204 (cherry picked it) plus two additional commits which add the missing parts to update to LLVM 11. I hope this clarifies it.

BTW, thanks everyone in the project. It is amazing how useful and effective it is!

Cheers, Josep M. Perez

On 8 Feb 2022, at 17:39, Eric Eide @.***> wrote:

Thank you for your contribution!

Do you know if your changes different than those on the existing llvm-11.0 branch? https://github.com/csmith-project/creduce/tree/llvm-11.0 https://github.com/csmith-project/creduce/tree/llvm-11.0 — Reply to this email directly, view it on GitHub https://github.com/csmith-project/creduce/pull/240#issuecomment-1032824699, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT6IVCSMWO7SIE6PL7QOZTDU2FBMXANCNFSM5N2OYIVA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

chenyang78 commented 2 years ago

@jmperez-et Thank you for the patch! Seems the patch does a similar fix as what we did for llvm-11.0 branch:

https://github.com/csmith-project/creduce/commit/3e1f5a1ec1365fafae965c97603221c9ccbc2d61

llvm-11.0 branch should work with LLVM 11. By the way, we don't actively maintain llvm-snv-compatible branch anymore. Instead, we have multiple branches that work with different LLVM releases at the moment. For example, we have llvm-11.0, llvm-12.0 and llvm-13.0 branches.

jmperez-et commented 2 years ago

Sorry, my bad. Somehow I did not realize there was already a branch for LLVM 11.

Cheers, Josep M. Perez

On 9 Feb 2022, at 19:21, Yang Chen @.***> wrote:

@jmperez-et https://github.com/jmperez-et Thank you for the patch! Seems the patch does a similar fix as what we did for llvm-11.0 branch:

https://github.com/csmith-project/creduce/commit/3e1f5a1ec1365fafae965c97603221c9ccbc2d61 llvm-11.0 branch should work with LLVM 11. By the way, we don't actively maintain llvm-snv-compatible branch anymore. Instead, we have multiple branches that work with different LLVM releases at the moment. For example, we have llvm-11.0, llvm-12.0 and llvm-13.0 branches.

— Reply to this email directly, view it on GitHub https://github.com/csmith-project/creduce/pull/240#issuecomment-1034061659, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT6IVCQHTYCL5VNI2KG7HLDU2KWC7ANCNFSM5N2OYIVA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

chenyang78 commented 2 years ago

Sorry, my bad. Somehow I did not realize there was already a branch for LLVM 11. Cheers, Josep M. Perez

No problem at all, @jmperez-et ! Again, thank you for sharing you patch with us. Since the issue has been resolved, I am closing the pull request.