Class Permission Change cpUpdate()

csmith1188 / Formbar.js

Javascript rewrite of Formbar, an open source classroom management tool.

6 stars 22 forks source link

Class Permission Change cpUpdate() #412

Closed luke24279 closed 5 months ago

luke24279 commented 5 months ago

The cpUpdate() function in the classPermChange socket.on in the app.js file has been commented out to fix another issue. Keep an eye out for potential bugs created by this change, and see if it is better to keep it commented and fix the new bugs or uncomment it and fix the old issue in a different way.

Luminocents commented 5 months ago

I investigated and have observed that whether or not the cpUpdate in the socket.on "classPermChange" in app.js is commented or not nothing changes. The issues I have seen while investigated that I think are supposed to be affected are as follows.

Does not save tag changes for other users without refreshing regardless if cpUpdate is commented out or not.
Manager page user tags just do nothing and also has different tags than home control panel. Is also unaffected from commenting out cpUpdate.