search

csn-le / wave_clus

A fast and unsupervised algorithm for spike detection and sorting using wavelets and super-paramagnetic clustering
121 stars 65 forks source link

Parameters setting in Do_clustering appears to be ignored #216

Closed Jibble1 closed 2 years ago

Jibble1 commented 2 years ago

First of all, thank you for the excellent software - it really is very nicely written and implemented. One thing that I'm a little confused about - entering some parameters as a 'par' input under Do_clustering seems to be completely ignored, for example: myPar = []; myPar.stdmin = 5; myPar.randomseed = 1; myPar.mintemp = 0.05; Do_clustering('myfile.mat', 'par', myPar)

Am I missing something here? I've tried setting ridiculous parameters to test, but it still seems to just use the ones in set_parameters. Appreciate your advice!

ferchaure commented 2 years ago

Hi jbrger, I will takea look, but at least stdmin is only used in Get_spikes. For that reason, the times will have the ones in the spikes file or if they aren't there will keep the ones in set_parameters.

Jibble1 commented 2 years ago

Ah, thank you. This was my ignorance then - I think I had simply missed off adding the parameters to Get_spikes as well as Do_clustering, so most of the parameters I was changing were relevant to the first function. Sorry for such a naïve question. Looking through the MATLAB code, I couldn't see how it wouldn't be taking account of the parameters.