csn-le / wave_clus

A fast and unsupervised algorithm for spike detection and sorting using wavelets and super-paramagnetic clustering
127 stars 66 forks source link

Minor bug with batch input to Do_clustering.m #219

Open ckfaber opened 2 years ago

ckfaber commented 2 years ago

I'm inputting a cell array of _spikes.mat files to Do_clustering.m. While the function is running through, the function does not give an accurate message on progression through the 'times' files - relevant code is in lines 166-180 of Do_clustering, specifically:

    `    disp(sprintf('%d of %d ''times'' files finished.',count_new_times(fnum, filenames),Nfiles))`

Mine just keeps saying 0 of 16 'times' files finished on every iteration of the loop. Should be an easy fix, hopefully!

Thanks for such great functions and documentation!

ferchaure commented 2 years ago

Hi, that is a timing issue related to how the parallel processing is done and the times associated to the files. How is done, makes sense for slower computers. I'm not actively fixing that type of non essential bugs, but I can accept a workaround if you make a pull request.