search

csnemes / tracer

Tracing rewriter using Fody
Apache License 2.0
93 stars 26 forks source link

Add ability to disable log parameters values #84

Open DanielDubeSp opened 5 years ago

DanielDubeSp commented 5 years ago

Passwords and any confidential info can be accidentally logged if parameter values are logged. We can put an attribute [NoTrace] but I think can be better to disable it globally. A new value on FodyWeawers.Xml will be also dangerous because an admin user can comment this 'disable' option. An attribute by assembly?

Thanks for your work and your time!!

csnemes commented 5 years ago

I can add an attribute, but I don't see how we can mark the confidential parameters. The weaver needs to decide whether to include it the param arrays or not. Alternatively the log adapter can decide (this time it gets the data, but it won't write it to the log), but the question still remains, how to decide what is confidential.

KaNarlist commented 4 years ago

Are there any news about this? For me it would be enough if I could disable lagging of parameter values completly.

csnemes commented 4 years ago

Added the possibility to use NoTrace on parameters and use NoReturnTrace on method to disable return value tracing.

KaNarlist commented 4 years ago

Cool!

But can you tell how I use these in my config?

`

`