Update for preview9 - Githubissues

csnewman / BlazorSignalR

SignalR Core C# client Blazor compatibility

MIT License

64 stars 21 forks source link

Update for preview9 #35

Closed jsakamoto closed 5 years ago

jsakamoto commented 5 years ago

Update for preview8

Updated / adjusted dependencies.
WebAssemblyUriHelper was gone, therefore, I changed the way to retrieve base URI. (invoke JavaScript interop, instead.)
Changed the class name from DotNetObjectRef to DotNetObjectReference.

csnewman commented 5 years ago

Overlaps with #36 going to need to take a look into the two PRs a bit more.

dazinator commented 5 years ago

@csnewman I took at look at this PR and competing one #36

NavigationManager on PR #36 is the correct way to go about things in preview 9 rather than introducing js interop, other than that these two PR's are pretty similar. Therefore i'd vote (sorry @jsakamoto) to abandon this PR in favour of #PR 36

jsakamoto commented 5 years ago

@dazinator Don't worry! I agree your opinion.

This PR is just my favorite way.

I sometimes prefer keep compatibility with some hack, rather than formal way with breaking change. That's it. 😄

csnewman commented 5 years ago

I agree with @dazinator. Thanks for creating this PR @jsakamoto, however I'm going to go with the other PR for the above listed reasons.

jsakamoto commented 5 years ago

@csnewman No problem!

Thank you for your kindly reply.

And, I appreciate to you that you publish these great products as a open source!