search

csoc-de / Shifts

MIT License
28 stars 7 forks source link

Allows for adding multiple of same Shift on same day #57

Open privatemaker opened 10 months ago

privatemaker commented 10 months ago

I am not sure if what I encountered was a bug from my actions, or an intended featured that I don't understand, and the UI display makes it look like a bug.

To walk through how I arrived, I created a ShiftType called Morning with value 1 set for each day of the week.

shifts-modal-shifttype-editor

Then from the Shifts plan view I clicked Add Shift button and filled out values as such.

shifts-modal-add-shift

When I first did this a handful of times, it did not seem to add after clicking Save so I clicked again. And again. And again... Then eventually after seeing no errors in console, I refreshed the page. VOILA!!! The result was:

shifts-doubling-of-added-shifts

Good, so it's properly adding shifts, just far too many. I had assumed the value 1 would limit it to one ShiftType on that given day of the week.

privatemaker commented 10 months ago

Upon viewing this in Chrome (above screenshot is in FF), the Shifts app properly expands the container for all items inside- so at least that part of this a cross-browser bug

shifts-doubling-of-added-shifts-chrome